This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Upgrade macOS and Windows installers to use SQLite 3.37.2
Type: Stage: resolved
Components: macOS, Windows Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: erlendaasland, kumaraditya, miss-islington, ned.deily, paul.moore, ronaldoussoren, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2021-11-29 11:57 by erlendaasland, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 30485 merged kumaraditya, 2022-01-08 12:41
PR 30921 merged kumaraditya, 2022-01-26 12:02
PR 30991 merged steve.dower, 2022-01-28 16:32
PR 30994 merged miss-islington, 2022-01-28 17:13
PR 31057 merged ned.deily, 2022-02-01 16:09
PR 31059 merged miss-islington, 2022-02-01 16:29
Messages (15)
msg407266 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-11-29 11:57
SQLite 3.37.0 was released a couple of days ago: https://sqlite.org/releaselog/3_37_0.html

Given that 3.11 feature freeze is approx. May 2022, and that it took approx. 5 months between SQLite 3.36.0 and 3.37.0, I'd say we aim for a field tested SQLite 3.37.0 instead of a possibly fresh-out-of-the-box 3.38.0 in 3.11.

Let's wait a couple of weeks before changing the macOS/Windows installers.
msg409493 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2022-01-02 11:04
SQLite 3.37.1 appeared the day before New Years Eve. So let us wait until the end of January before upgrading the installers.

https://www.sqlite.org/releaselog/3_37_1.html
msg409919 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2022-01-06 20:26
SQLite 3.37.2 is fresh out now. Copying the release statement from the SQLite forum:

    Patch release 3.37.2 fixes a potential database corruption bug.
    Upgrading is recommended for all users.
    
    The database corruption bug is obscure and you are unlikely to hit it.
    But you should probably still upgrade.  For more information about
    the bug see:
    
     *  https://sqlite.org/forum/forumpost/ac381d64d8


Link to the release page: https://www.sqlite.org/releaselog/3_37_2.html


We should consider backporting to 3.10 and 3.9 due to the severity of the bug.
msg409920 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2022-01-06 20:29
Quoting the SQLite forum post, regarding backporting:

    There is a bug in versions 3.35.0 (2021-03-12) through 3.37.1 (2021-12-30)
    which could potentially cause database corruption. Upgrading to version
    3.37.2 (2022-01-06) or later is recommended.


The Python 3.10 Windows and macOS installers ship with SQLite 3.36.0, so they are vulnerable to this bug. Ditto for the Python 3.9 Windows and macOS installers which ship with SQLite 3.35.5.
msg409931 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-01-06 21:31
Are we enabling the build option they mention on the release page? Or is 
this only going to affect users who use the pragma?

We should obviously do the upgrade, but that will determine how 
aggressively we ought to be messaging the issue.
msg409932 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2022-01-06 21:41
As I understand the forum post, you're vulnerable if you use that specific build option (we don't), _or_ if you use the pragma (anyone may do that). So AFAICS, we should upgrade.
msg409934 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-01-06 22:24
We should definitely upgrade, but we probably don't have to trigger a 
fresh release of all branches for it, or make a big fuss about it being 
a special fix. That's all I was trying to establish.
msg409936 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2022-01-06 22:41
No, I don’t think we need to rush a new release. The scheduled 3.10 and 3.9 releases should do fine.

Can you update the sources repo in the mean time?
msg410018 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-01-07 19:51
> Can you update the sources repo in the mean time?

Done
msg412004 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-01-28 16:29
New changeset db77bcd6092f3c174ae855522411ab83854d65a8 by Kumar Aditya in branch 'main':
bpo-45925: Update Windows installer to SQLite 3.37.2 (GH-30485)
https://github.com/python/cpython/commit/db77bcd6092f3c174ae855522411ab83854d65a8
msg412018 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-01-28 17:13
New changeset 4d191fcde426ca0643d961aa18e787103f05fce2 by Steve Dower in branch '3.10':
bpo-45925: Update Windows installer to SQLite 3.37.2 (GH-30485)
https://github.com/python/cpython/commit/4d191fcde426ca0643d961aa18e787103f05fce2
msg412019 - (view) Author: miss-islington (miss-islington) Date: 2022-01-28 17:58
New changeset ad9cf2fdd39968b07e04136c8b50f65a4596c087 by Miss Islington (bot) in branch '3.9':
bpo-45925: Update Windows installer to SQLite 3.37.2 (GH-30485)
https://github.com/python/cpython/commit/ad9cf2fdd39968b07e04136c8b50f65a4596c087
msg412284 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2022-02-01 15:58
New changeset 0e4bef7a7f6f25a6f39755778c73e7026901611f by Kumar Aditya in branch 'main':
bpo-45925: Update macOS installer to SQLite 3.37.2 (GH-30921)
https://github.com/python/cpython/commit/0e4bef7a7f6f25a6f39755778c73e7026901611f
msg412287 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2022-02-01 16:29
New changeset 519eb6ad74f946a9aa7676e2d6579a3a765a8b50 by Ned Deily in branch '3.10':
bpo-45925: Update macOS installer to SQLite 3.37.2 (GH-30921) (GH-31057)
https://github.com/python/cpython/commit/519eb6ad74f946a9aa7676e2d6579a3a765a8b50
msg412295 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2022-02-01 17:13
New changeset a22dd00f2da4f6ff96f58fd8d551f16bdb870c8d by Miss Islington (bot) in branch '3.9':
bpo-45925: Update macOS installer to SQLite 3.37.2 (GH-30921) (GH-31057) (GH-31059)
https://github.com/python/cpython/commit/a22dd00f2da4f6ff96f58fd8d551f16bdb870c8d
History
Date User Action Args
2022-04-11 14:59:52adminsetgithub: 90083
2022-02-01 17:13:42ned.deilysetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2022-02-01 17:13:06ned.deilysetmessages: + msg412295
2022-02-01 16:29:13miss-islingtonsetpull_requests: + pull_request29241
2022-02-01 16:29:10ned.deilysetmessages: + msg412287
2022-02-01 16:09:46ned.deilysetpull_requests: + pull_request29239
2022-02-01 15:58:47ned.deilysetmessages: + msg412284
2022-01-28 17:58:07miss-islingtonsetmessages: + msg412019
2022-01-28 17:13:32miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request29175
2022-01-28 17:13:26steve.dowersetmessages: + msg412018
2022-01-28 16:32:19steve.dowersetpull_requests: + pull_request29171
2022-01-28 16:29:41steve.dowersetmessages: + msg412004
2022-01-26 12:02:21kumaradityasetpull_requests: + pull_request29100
2022-01-08 12:41:38kumaradityasetkeywords: + patch
nosy: + kumaraditya

pull_requests: + pull_request28689
stage: patch review
2022-01-07 19:51:48steve.dowersetmessages: + msg410018
2022-01-06 22:41:56erlendaaslandsetmessages: + msg409936
2022-01-06 22:24:38steve.dowersetmessages: + msg409934
2022-01-06 21:41:37erlendaaslandsetmessages: + msg409932
2022-01-06 21:31:17steve.dowersetmessages: + msg409931
2022-01-06 20:30:19erlendaaslandsetversions: + Python 3.9
2022-01-06 20:29:58erlendaaslandsetmessages: + msg409920
versions: + Python 3.10
2022-01-06 20:26:45erlendaaslandsettitle: Upgrade macOS and Windows installers to use SQLite 3.37.1 -> Upgrade macOS and Windows installers to use SQLite 3.37.2
2022-01-06 20:26:36erlendaaslandsetmessages: + msg409919
2022-01-02 11:04:14erlendaaslandsetmessages: + msg409493
title: Upgrade macOS and Windows installers to use SQLite 3.37.0 -> Upgrade macOS and Windows installers to use SQLite 3.37.1
2021-11-29 11:57:19erlendaaslandcreate